Skip to content

JavaScript (v3): S3 - Audit 🧵 2/ #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 7, 2024
Merged

JavaScript (v3): S3 - Audit 🧵 2/ #6956

merged 10 commits into from
Oct 7, 2024

Conversation

@cpyle0819
Copy link
Contributor

@cpyle0819 cpyle0819 commented Oct 4, 2024

  • Replace hard coded bucket names with user input.
  • Update any example bucket names to be in accordance with guidelines.
  • Update several S3 examples to make latest code example standards for JS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819
JavaScript (v3): S3 - Replace hard coded bucket names with env vars o…
e8f1251 
…r allowable name.
@cpyle0819
JavaScript (v3): S3 - Update runners and bucket names to match latest…
be7503e 
… guidance.
@cpyle0819
JavaScript (v3): S3 - Standardize multipart upload example.
c558a90
@cpyle0819
JavaScript (v3): S3 - Update dependencies and add lib-storage.
608a5fc
@cpyle0819
JavaScript (v3): S3 - Update multipart upload scenario.
9ee33d0 
The multipart upload scenario was using the lower level
"CreateMultipartUpload" API. The JS SDK provides an 'Upload'
API as part of 'lib-storage' that simplifies this process.
This change replaces the existing example with the lib-storage
usage and adds a progress bar util.
@cpyle0819
JavaScript (v3): S3 - Standardize presigned-url upload example.
f645021
@cpyle0819
JavaScript (v3): S3 - Standardize presigned-url download example.
4e90ee6
@cpyle0819
JavaScript (v3): S3 - Standardize multi-part download example.
bdef929
@cpyle0819
JavaScript (v3): S3 - Add brief readme to the web example.
dff4f6c
@cpyle0819 cpyle0819 added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Oct 4, 2024
@cpyle0819 cpyle0819 requested a review from a team October 4, 2024 20:05
@cpyle0819 cpyle0819 self-assigned this Oct 4, 2024
@cpyle0819 cpyle0819 requested review from ford-at-aws and removed request for a team October 4, 2024 20:05
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Oct 4, 2024
@cpyle0819 cpyle0819 requested review from a team and beqqrry-aws and removed request for a team and ford-at-aws October 7, 2024 14:12
@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Oct 7, 2024
@DavidSouther DavidSouther added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 7, 2024
@DavidSouther DavidSouther merged commit f13e958 into awsdocs:main Oct 7, 2024
18 of 20 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/s3-audit branch November 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beqqrry-aws beqqrry-aws beqqrry-aws approved these changes

Assignees

@cpyle0819 cpyle0819

Labels

Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpyle0819 @beqqrry-aws @DavidSouther